Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve natvis #42

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Improve natvis #42

merged 1 commit into from
Mar 25, 2024

Conversation

K-ballo
Copy link
Member

@K-ballo K-ballo commented Mar 23, 2024

  • extend support from 10 to 40 alternatives,
  • split single-buffer vs double-buffer definitions,
  • adjust display string to follow MS definition for std::variant

- extend support from 10 to 40 alternatives,
- split single-buffer vs double-buffer definitions,
- adjust display string to follow MS definition for std::variant
@pdimov
Copy link
Member

pdimov commented Mar 23, 2024

@vinniefalco Any objections to this?

@vinniefalco
Copy link
Member

Looks better than my version, so if this works I would give it a three thumbs up.

@vinniefalco
Copy link
Member

@K-ballo did you test this?

@K-ballo
Copy link
Member Author

K-ballo commented Mar 24, 2024

@K-ballo did you test this?

Here are some examples:

variant<bool, int, double> v0{ 0.0 }; // single storage
variant<bool, int, double, int, int, int, int, int, int, int> v1{ 1.0 }; // 10 elements storage
variant<evil, bool, int, double> v2{ 2.0 }; // double storage
variant<evil, bool, int, double> v3; // double storage
v3.emplace<double>(3.0); // use second storage

image

@pdimov pdimov merged commit ff36c3a into boostorg:develop Mar 25, 2024
57 checks passed
@K-ballo K-ballo deleted the more-natvis branch March 25, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants