Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peeks for idents #367

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Daniil159x
Copy link

Hi!
I found the project very useful. And my usual workflow looks like that: click on some ident and open N new tabs for reference/definition. But in other code view apps I can "peek" source (e. g. https://code.visualstudio.com/docs/editor/editingevolved#_peek, or github).
I have added this feature in single page and dynamic popup:

sb_bread
adfs_error

The changes bring performance impact, but i hope caching handles it.
You can try it on my instance: https://elixir.ravin.gs.

@tleb
Copy link
Member

tleb commented Dec 25, 2024

Thanks for that rather consequent feature! I'll be able to give feedback and discuss next week.

You might have seen we faced some annoying performance issues recently (#365), so we'll have to let it rest a bit to add features that worsen performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants