Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web, banner: Add dynamic messages for mobile version #369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fstachura
Copy link
Collaborator

@fstachura fstachura commented Dec 29, 2024

New design:
screenshot

@tleb
Copy link
Member

tleb commented Jan 31, 2025

Not a fan of the design. Two proposals. First one takes inspiration from your mobile but reduces font size and uses bold. Second one reuses the desktop banner and moves it around. On the second I also reworked the nav links for them to have fluid padding inbetween them. That way they only take a single line, avoiding spending vertical space for nothing. I'll submit that in a separate PR.

Screenshot 2025-01-31 at 21-05-04 Musl source code (v1 2 5)

Screenshot 2025-01-31 at 21-15-58 Musl source code (v1 2 5)

I did it in devtools but I could recreate them properly if that works out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants