Makefile: fix parallel compilation using inkscape #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inkscape does DBus accesses at startup to look for other running instances. The feature fails quite often for some obscure reason. Disable it using (undocumented) SELF_CALL environment variable. Code doing it in Inkscape: https://gitlab.com/inkscape/inkscape/-/blob/a77b160f/src/inkscape-application.cpp#L557 They set it for their child extensions: https://gitlab.com/inkscape/inkscape/-/blob/0b4d3151/src/extension/extension.cpp#L529-530 Found in a bug comment: https://gitlab.com/inkscape/inkscape/-/issues/4716#note_1898150983 Computation of INKSCAPE_IS_NEW must be done using the same variable as we do recursive make calls. Before: ⟩ make clean ⟩ make -j20 full-linux-kernel-slides.pdf make: *** [Makefile:271: <...PATH-TO-TRAINING-MATERIALS...>/out/./common/sd-card.pdf] Error 134 make: *** Waiting for unfinished jobs.... make: *** [Makefile:271: <...PATH-TO-TRAINING-MATERIALS...>/out/./common/qemu-logo.pdf] Error 134 make: *** [Makefile:269: <...PATH-TO-TRAINING-MATERIALS...>/out/./common/strace-c-output.pdf] Error 134 make: *** [Makefile:269: <...PATH-TO-TRAINING-MATERIALS...>/out/./agenda/qemu-logo.pdf] Error 134 make: *** [Makefile:269: <...PATH-TO-TRAINING-MATERIALS...>/out/./common/gdb-vs-gdbserver.pdf] Error 134 make: *** [Makefile:269: <...PATH-TO-TRAINING-MATERIALS...>/out/./common/logo-cc.pdf] Error 134 ⟩ # note that failing targets is random and changes on each call After: ⟩ make clean ⟩ make -j20 full-linux-kernel-slides.pdf ⟩ # works without errors Signed-off-by: Théo Lebrun <[email protected]>
tleb
force-pushed
the
fix-concurrent-builds
branch
from
b3413d8 to
ff32eb2
Compare
|
After feedback in direct messages, I merged the patch as e16c791. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inkscape does DBus accesses at startup to look for other running instances. The feature fails quite often for some obscure reason. Disable it using (undocumented) SELF_CALL environment variable.
Before:
After:
Posting as a PR as I would appreciate a round of review before pushing to the master branch.