-
Notifications
You must be signed in to change notification settings - Fork 10
Added _bscore_woocommerce.scss collector #5
Conversation
I'm not quite sure if the actual file _bscore_woocommerce.scss is existing in that commit. If not, I would add it with a short comment just to explain why its there and empty. |
File is in parent theme and there is a comment why it's still empty https://github.com/bootscore/bootscore/pull/41/files |
Added a short description to import files. PR in parent theme must be merged first https://github.com/bootscore/bootscore/pull/41/files |
@Axos11 since the talk this morning, I should more explain why things are as they are and what's the goal of it at the end. In earlier Version, theme had 4 enqueued CSS files:
The bootstrap.min.css is enqueued in existing child-theme installations and we cannot change this name roughly without crashing users themes. Adding Bootstrap source and compiler was a game changer. We decided to do move step-by-step all files to SCSS and merge them into one enqueued CSS file add the end. For each step, user must update his child. An update guide is written in the blog and user gets informed by newsletter.
What I mean with that is, that something like name bootstrap.min.css is confusing, because this file contains more than Bootstrap. But we have to change this step-by-step. First catch all css to scss and delete css files, then pushing to style.css. Please check PR bootscore/bootscore#41 in parent theme as well. Maybe it's more clear because both are related to each other. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Adding
_bscore_woocommerce.scss
for Pull request #41