Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement "borg version", fixes #7829 #8053

Merged

Conversation

ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Jan 19, 2024

Since long, we have borg --version to display the borg (client) version string in its very detailed form provided by setuptools_scm, e.g.:

borg 1.4.0.dev119+gc7cef548.d20240119

Now there is an additional new command "borg version ", which shows the client / server version, e.g.:

1.4.0a / 1.2.7

If a local repo is given, the client code directly accesses the repository, thus we show the client version also as the server version.

If a remote repo is given (e.g. ssh:), the remote borg is queried and its version is displayed as the server version.

Due to the version tuple format used in borg client/server negotiation, only a simplified version is displayed (as provided by borg.version.format_version).

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (319441e) 82.56% compared to head (fe3cda8) 82.48%.
Report is 2 commits behind head on 1.4-maint.

❗ Current head fe3cda8 differs from pull request most recent head 8d72927. Consider uploading reports for the commit 8d72927 to get more accurate results

Files Patch % Lines
src/borg/archiver.py 41.66% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           1.4-maint    #8053      +/-   ##
=============================================
- Coverage      82.56%   82.48%   -0.08%     
=============================================
  Files             38       38              
  Lines          10913    10925      +12     
  Branches        2084     2086       +2     
=============================================
+ Hits            9010     9012       +2     
- Misses          1345     1355      +10     
  Partials         558      558              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Additional new command "borg version <REPO>" which shows client and server version.
@ThomasWaldmann ThomasWaldmann merged commit 266c9f6 into borgbackup:1.4-maint Jan 19, 2024
9 of 10 checks passed
@ThomasWaldmann ThomasWaldmann deleted the remote-version-1.4 branch January 19, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants