Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8522: Add {unixtime} placeholders #8673

Conversation

abhijeetsharma200
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.82%. Comparing base (1559a1e) to head (64aa901).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8673      +/-   ##
==========================================
- Coverage   81.83%   81.82%   -0.02%     
==========================================
  Files          74       74              
  Lines       13319    13348      +29     
  Branches     1963     1971       +8     
==========================================
+ Hits        10900    10922      +22     
- Misses       1755     1761       +6     
- Partials      664      665       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann ThomasWaldmann merged commit 4eef617 into borgbackup:master Feb 24, 2025
16 checks passed
@ThomasWaldmann
Copy link
Member

Thanks! Can you please do a backport to 1.4-maint branch?

@abhijeetsharma200
Copy link
Contributor Author

Thanks! Can you please do a backport to 1.4-maint branch?

Sure! I’ve never done a backport before. Just to confirm, I should branch off from 1.4, apply the same changes, and create a PR targeting 1.4. Is that correct?

@ThomasWaldmann
Copy link
Member

one usually would:

  • git checkout 1.4-maint
  • git checkout -b feature_8522_add_unixtime_to_placeholders-1.4
  • git cherry-pick (add hash here for the changeset in master branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants