Improve build time when updating Boost flags #1944
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across an interesting article that gives recommendations on how to set preprocessor flags such that it improves build time.
The key idea is to get rid of
add_definitions
calls in CMake since it passes the preprocessor flag to all cpp files, and instead use a definition within theconfig.h.in
file. This would then only require re-compiling files that includegtsam/config.h
and not the complete project in the event the flags were updated.Since we already have the
config.h.in
, this was an easy update.I recommend reading the article, since it also discusses the benefits of using
#cmakedefine01
over#cmakedefine
.