Remove operator^ from Matrix and SubgraphPreconditioner #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eigen recently added an operator^ for coefficient-wise bitwise xor, which conflicts with gtsam's operator^. Since gtsam's operator^ isn't xor, I opted to remove it. Fixes borglab#1951.
|
Thanks! The patch was yours in the first place <3 |
dellaert
reviewed
Jan 10, 2025
|
Thanks for doing this ! The CI fails on testMatrix.cpp, though. You can check at least the unit tests on your platform with “make check”. |
|
PS @calcmogul / Tyler, looking at your website, I’d gladly welcome your input on IP methods for GTSAM. @yetongumich did a PhD thesis on constrained optimization using “synthesized” manifolds, and he’s working on a few PRs that will include some IP methods, I think. He can comment more - but it’d be great to have an extra set of eyes on those :-) |
|
Two of the test files don't compile for me with GCC 14, even on develop: |
I'd be happy to. Some IPMs that properly deal with manifolds would be really good to have. |
2 tasks
|
I had to apply this diff, but otherwise works with newer Eigen for me! Why might CI here be missing cassert includes, but I'm hitting them locally with gcc diff --git a/gtsam/basis/Chebyshev2.cpp b/gtsam/basis/Chebyshev2.cpp
index 71c3db7f0..df7bf5f19 100644
--- a/gtsam/basis/Chebyshev2.cpp
+++ b/gtsam/basis/Chebyshev2.cpp
@@ -17,6 +17,7 @@
*/
#include <gtsam/basis/Chebyshev2.h>
+#include <cassert>
namespace gtsam {
|
|
(I'm also seeing this in our CI as well) |
Might need to cast explicitly or use an explicit template. |
dellaert
approved these changes
Jan 11, 2025
calcmogul
deleted the
remove-operator-from-matrix-and-subgraph-preconditioner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eigen recently added an operator^ for coefficient-wise bitwise xor, which conflicts with gtsam's operator^. Since gtsam's operator^ isn't xor, I opted to remove it.
Fixes #1951.