Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dead link from kms-example-encrypt-decrypt-file.rst #4452

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+0 −3
Open

Removed dead link from kms-example-encrypt-decrypt-file.rst #4452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions docs/source/guide/kms-example-encrypt-decrypt-file.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ example, with the ``pip`` command.

pip install cryptography

Each section describes a single function from the example's `entire
source file <https://github.com/awsdocs/aws-doc-sdk-examples/tree/master/python/example_code/kms/encrypt_decrypt_file.py>`_.

Comment on lines -32 to -34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should potentially have @shepazon or @meyertst-aws do a look over this to see if we need to make other updates. It looks like the samples below are intended to be inline with the linked repo, we've updated the content there but not here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look at this as soon as possible. Hopefully today.

Copy link
Contributor

@shepazon shepazon Feb 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I believe this change can be merged and deployed as-is. The existing sample code that's in the guide is still valid. I have filed a ticket that is on my backlog to update the guide content to center on the new examples, however.


Retrieve an existing master key
===============================
Expand Down
Loading