User agent 2.1: Propagate Botocore context to child threads #335
+49
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan343
reviewed
Feb 25, 2025
| @@ -17,6 +17,8 @@ | |||
| from collections import namedtuple | |||
| from concurrent import futures | |||
|
|
|||
| from botocore.context import get_context | |||
There was a problem hiding this comment.
The current version requirement for s3transfer is:
requires = [
'botocore>=1.36.0,<2.0a.0',
]We should bump the minimum supported version to prevent import errors since the botocore.context won't exist in versions between 1.36.0 and the version that releases boto/botocore#3389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to boto/botocore#3389
Description
Context variables aren't automatically propagated from parent to child threads. To ensure the Botocore client captures features registered outside of concurrent context, we need to explicitly get and pass the context to the thread pool executor.