selinux: Add network_exec label for systemd-networkd
#3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmrow
force-pushed
the
networkd-selinux
branch
2 times, most recently
from
b977872
to
5e5dbcb
Compare
arnaldo2792
approved these changes
Aug 2, 2023
packages/selinux-policy/fs.cil
Outdated
| @@ -51,6 +51,8 @@ | |||
| (filecon "/.*/usr/sbin/chronyd" file clock_exec) | |||
| (filecon "/.*/usr/sbin/wicked.*" file network_exec) | |||
| (filecon "/.*/usr/libexec/wicked/bin/wicked.*" file network_exec) | |||
| (filecon "/.*/usr/lib/systemd/systemd-networkd" file network_exec) | |||
There was a problem hiding this comment.
I wonder if you could do what is already in the policy for wicked a few lines above:
(filecon "/.*/usr/lib/systemd/systemd-networkd*" file network_exec)
cbgbt
approved these changes
Aug 3, 2023
bcressey
approved these changes
Aug 4, 2023
This change adds the network_exec label to systemd-networkd and systemd-networkd-wait-online, which is what wicked currently has and gives access to /etc and DBUS.
|
^ Adds the wildcard @arnaldo2792 suggested |
yeazelm
approved these changes
Aug 4, 2023
arnaldo2792
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related to #2449
Description of changes:
This change adds the network_exec label to systemd-networkd and systemd-networkd-wait-online, which is what
wickedcurrently has and which gives access to/etcand DBUS .Testing done:
aws-k8s-1.24variant as a sanity check; it comes up and joins the cluster properly. No spurious AVC denial messages in the journal.aws-devvariant with systemd-networkd enabled and ensure the right label is placedsystemd-networkdandsystemd-networkd-wait-online. Also make sure no AVC denial messages showed up in the journal.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.