Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Docker host header fix for Go 1.20.6+ changes #3312

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

stmcginnis
Copy link
Contributor

@stmcginnis stmcginnis commented Aug 3, 2023

Issue number:

N/A

Description of changes:

Starting with Go 1.20.6, there was a security fix that changed the behavior when making local socket connections. It now requires a valid host header to be present, causing an error when connecting. This has since been fixed upstream, but only in the newer versions of Docker.

This change backports the fix to our version of docker-engine and docker-cli.

Testing done:

Prior to applying this change, troubleshooting with the docker CLI on the console would give the error:

bash-5.1# docker run -it --rm --name testing fedora bash
http: invalid Host header

After applying, able to successfully using docker to run a container:

bash-5.1# docker run --rm -it fedora bash
[root@0f253dcfff6a /]#

Full ECS testing run by @arnaldo2792 and passed (thanks!!)

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@stmcginnis stmcginnis marked this pull request as draft August 3, 2023 13:50
@stmcginnis
Copy link
Contributor Author

Not directly related, but also ran sonobuoy run --mode certified-conformance on an aws-k8s-1.27 cluster to verify no issues having been built with Go 1.20.6.

20:51:51             e2e                                         global   complete   passed   Passed:378, Failed:  0, Remaining:  0
20:51:51    systemd-logs     ip-192-168-3-13.us-east-2.compute.internal   complete   passed

Copy link
Contributor

@arnaldo2792 arnaldo2792 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ECS internal testing passed

@stmcginnis stmcginnis merged commit 341e9fe into bottlerocket-os:develop Aug 8, 2023
42 checks passed
@stmcginnis stmcginnis deleted the docker-test branch August 8, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants