Patch Docker host header fix for Go 1.20.6+ changes #3312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Starting with Go 1.20.6, there was a security fix that changed the behavior when making local socket connections. It now requires a valid host header to be present, causing an error when connecting. This has since been fixed upstream, but only in the newer versions of Docker.
This change backports the fix to our version of docker-engine and docker-cli.
Testing done:
Prior to applying this change, troubleshooting with the
docker
CLI on the console would give the error:After applying, able to successfully using
docker
to run a container:bash-5.1# docker run --rm -it fedora bash [root@0f253dcfff6a /]#
Full ECS testing run by @arnaldo2792 and passed (thanks!!)
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.