-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pluto: retry on empty private-dns-name from EC2 #3364
pluto: retry on empty private-dns-name from EC2 #3364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Re-evaluating approach since there is potentially a valid combination of VPC configuration and kubelet/aws-iam-authenticator configurations where a node can still join a cluster where private DNS name is empty. |
Use fibonacci backoff on requests to EC2 for fetching the private DNS name of the instance. Retry on both API failures and on when the private DNS name is empty.
68266a2
to
0a8e08b
Compare
@etungsten did you determine that no such valid combination exists or would ever have worked on Bottlerocket previously? That's my current understanding. |
There is a very fringe case where a user can potentially set up a bootstrap container to set their own |
Issue number:
Resolves #3363
Description of changes:
Testing done:
Instance comes up fine. Directly calling pluto works:
On an instance where hostname is resource-based in the subnet:
On an instance where hostname is IP based:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.