Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cargo-readme #3397

Closed
wants to merge 1 commit into from
Closed

Conversation

webern
Copy link
Contributor

@webern webern commented Sep 1, 2023

Issue number:

N/A
Related to webern/cargo-readme#84

Description of changes:

Update Cargo readme to update its dependencies.

Testing done:

If the build works, we're good.

TODO

  • Publish to crates.io and use that

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@webern webern force-pushed the cargo-readme branch 2 times, most recently from 5f6b485 to e2395c1 Compare September 2, 2023 00:24
tools/deny.toml Outdated Show resolved Hide resolved
tools/deny.toml Outdated Show resolved Hide resolved
sources/deny.toml Outdated Show resolved Hide resolved
sources/generate-readme/Cargo.toml Outdated Show resolved Hide resolved
@webern
Copy link
Contributor Author

webern commented Sep 2, 2023

@ecpullen This function might be gone from toml, is this a big problem? I looked around and I don't see it in docs.rs or anything that sounds similar.

@webern
Copy link
Contributor Author

webern commented Sep 5, 2023

@webern
Copy link
Contributor Author

webern commented Sep 5, 2023

@webern
Copy link
Contributor Author

webern commented Sep 5, 2023

# Tough is using an older version of globset which is using
# an older version of aho-corasick
{ name = "aho-corasick", version = "=0.7" },
# Netdog is using a feature of toml 0.5 that does not exist in
Copy link
Contributor Author

@webern webern Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmrow and @yeazelm 😢

#3422

@jpculp
Copy link
Member

jpculp commented Oct 17, 2023

I went ahead and bumped cargo-readme in #3532, but without bumping toml elsewhere since I don't think it will impact the binaries themselves. I suspect we'll want to use this PR to move everything else to toml 0.7 at the same time.

@webern
Copy link
Contributor Author

webern commented Oct 30, 2023

I'm going to close this as it's not clear when I will get back to it. Sorry.

@webern webern closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants