netdog: Add BindCarrier to bond network files #3426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #3425
Description of changes:
networkd will lose track of carrier for worker devices in a bond when bringing it up. This causes a delay in the bond becoming routable while the devices re-establish carrier status. This change adds BindCarrier to bond .network files which ensures networkd brings up the bond if at least one link has carrier.
Testing done:
This produces quicker boots and the bonds become routable quickly as expected:
The backstop message still appears, but the network is useable well before this (fetched immediately after my
metal-dev
instance booted and provided a login prompt:Tests were also updated to ensure this change shows up in the resulting configurations.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.