-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bootstrap commands #4131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI failed with
Can you format your code? |
ytsssun
reviewed
Aug 7, 2024
piyush-jena
force-pushed
the
develop
branch
5 times, most recently
from
August 9, 2024 21:49
6c4fc5a
to
2a6f28e
Compare
yeazelm
reviewed
Aug 12, 2024
sources/settings-migrations/v1.21.0/bootstrap-commands-config-file-v0-1-0/src/main.rs
Outdated
Show resolved
Hide resolved
piyush-jena
force-pushed
the
develop
branch
7 times, most recently
from
August 20, 2024 21:41
6361f34
to
623b982
Compare
piyush-jena
force-pushed
the
develop
branch
3 times, most recently
from
August 31, 2024 07:08
ec44d29
to
f4d5488
Compare
bcressey
reviewed
Sep 3, 2024
sources/settings-migrations/v1.22.0/bootstrap-commands-services-cfg-v0-1-0/src/main.rs
Outdated
Show resolved
Hide resolved
piyush-jena
force-pushed
the
develop
branch
2 times, most recently
from
September 4, 2024 09:47
2208c47
to
fd6487e
Compare
Forced push resolves the following:
|
bcressey
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need the final commits after the settings SDK release.
yeazelm
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ginglis13
approved these changes
Sep 4, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #
Description of changes:
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.