fix: update permission bits for kubelet-exec-start-conf #4199
Conversation
Sparksssj
changed the title
sources/settings-migrations/v1.23.0/kubernetes-service-config/src/main.rs
Outdated
Show resolved
Hide resolved
Sparksssj
force-pushed
the
develop
branch
2 times, most recently
from
db34fe9
to
719dbc8
Compare
|
Can you verify that the file permissions are not flagged by the CIS Kubernetes report (at either level)? |
Sorry but I'm not quite understand what this means. |
On an image with your changes applied, run this command and check the output: It needs to continue to say "PASS" for both the 4.1.1 check and the final result. |
|
It would also be good to check the journal before and after, to confirm that the warnings are no longer logged. |
|
|
|
@Sparksssj can you also verify that the warnings from the related issue are no longer present? |
Yes I confirm that this warning exist in previous version, and disappeared after the change. |
sources/Cargo.toml
Outdated
| @@ -55,6 +55,7 @@ members = [ | |||
| "settings-migrations/v1.23.0/nvidia-container-runtime-settings", | |||
| "settings-migrations/v1.23.0/kubelet-device-plugins-metadata", | |||
| "settings-migrations/v1.23.0/kubelet-device-plugins-settings", | |||
| "settings-migrations/v1.23.0/kubernetes-service-config", | |||
There was a problem hiding this comment.
Since, we released v1.23.0 yesterday, you will have to aim for 1.24.0 or 1.24.1. You will have to rebase and add the migration files to the appropriate directory.
Sparksssj
force-pushed
the
develop
branch
2 times, most recently
from
7e4a696
to
0f03b1c
Compare
Sparksssj
force-pushed
the
develop
branch
2 times, most recently
from
ad21f25
to
645f7f4
Compare
Issue number:
Closes #4173
Description of changes:
Changed the mode code for configuration-files.kubelet-exec-start-conf, such that it will not generate error message.
Testing done:
Required migration test was done.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.