-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to core-kit 3.0.0 #4251
Update to core-kit 3.0.0 #4251
Conversation
Now that krane builtin to twoliter, we don't need special instructions for the containerd-snapshotter in the docker daemon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though as a nit I'd include the core-kit & SDK versions in the commit message.
- Also fix clippy warning. Signed-off-by: Yutong Sun <[email protected]>
The Bottlerocket core kit 3.0.0 changes the name of the kmod-5.10-nvidia tesla package from kmod-5.10-nvidia-tesla-470 to kmod-5.10-nvidia-tesla-535 due to the NVIDIA branch offered by this package. Signed-off-by: Matthew Yeazel <[email protected]>
5e19713
to
8d1b1f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming the builds pass!
Description of changes:
0.5.0
.3.0.0
.0.46.0
.kmod-5.10-nvidia-tesla-470
tokmod-5.10-nvidia-tesla-535
. The Bottlerocket core kit 3.0.0 changes the name of the kmod-5.10-nvidia tesla package fromkmod-5.10-nvidia-tesla-470
tokmod-5.10-nvidia-tesla-535
due to the NVIDIA branch offered by this package. This change only affects one variant and is done on a major version bump for the core kit.Testing done:
cargo make unit-tests
cargo make check-fmt
cargo make check-clippy
cargo make check-shell
cargo make -e BUILDSYS_VARIANT=aws-k8s-1.24
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.