Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration for the new aws-config setting generator #4268

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

ginglis13
Copy link
Contributor

@ginglis13 ginglis13 commented Oct 25, 2024

Issue number:

n/a

Description of changes:

Add migration for the new aws_config setting generator.

Testing done:

Upgrade, non FIPS AMI, `settings.aws.config` null:
bash-5.1# apiclient get os

bash-5.1# apiclient get settings.aws
{
  "settings": {
    "aws": {
      "profile": "default",
      "region": "us-west-2"
    }
  }
}

After upgrade:

bash-5.1# apiclient get os

bash-5.1# apiclient get settings.aws
{
  "settings": {
    "aws": {
      "config": "W2RlZmF1bHRdCnVzZV9maXBzX2VuZHBvaW50PWZhbHNl",
      "profile": "default",
      "region": "us-west-2"
    }
  }
}

Downgrade (the setting remains):

bash-5.1# apiclient get settings.aws
{
  "settings": {
    "aws": {
      "config": "W2RlZmF1bHRdCnVzZV9maXBzX2VuZHBvaW50PWZhbHNl",
      "profile": "default",
      "region": "us-west-2"
    }
  }
}
Upgrade, non FIPS AMI, `settings.aws.config` already set: ``` bash-5.1# apiclient get os

bash-5.1# apiclient get settings.aws
{
"settings": {
"aws": {
"config": "W2RlZmF1bHRdCnJldHJ5X21vZGU9c3RhbmRhcmQK",
"profile": "default",
"region": "us-west-2"
}
}
}


After upgrade:

bash-5.1# apiclient get os

bash-5.1# apiclient get settings.aws
{
"settings": {
"aws": {
"config": "W2RlZmF1bHRdCnJldHJ5X21vZGU9c3RhbmRhcmQK",
"profile": "default",
"region": "us-west-2"
}
}
}



Downgrade (the setting remains):

bash-5.1# apiclient get settings.aws
{
"settings": {
"aws": {
"config": "W2RlZmF1bHRdCnJldHJ5X21vZGU9c3RhbmRhcmQK",
"profile": "default",
"region": "us-west-2"
}
}
}

</details>

**Terms of contribution:**

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@ginglis13 ginglis13 force-pushed the aws-config-migration branch from beffed2 to ba40809 Compare October 25, 2024 17:49
Copy link
Contributor

@bcressey bcressey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM once we're ready with the core kit release.

@ginglis13 ginglis13 force-pushed the aws-config-migration branch from ba40809 to d240fd0 Compare October 28, 2024 20:19
@ginglis13 ginglis13 changed the title Add migration for the new aws_config setting generator Add migration for the new aws-config setting generator Oct 29, 2024
Add migration for the new aws-config setting generator.

Signed-off-by: Gavin Inglis <[email protected]>
@ginglis13 ginglis13 force-pushed the aws-config-migration branch from d240fd0 to 0435a67 Compare November 7, 2024 04:27
@ginglis13 ginglis13 marked this pull request as ready for review November 7, 2024 04:56
@ginglis13 ginglis13 requested a review from bcressey November 7, 2024 16:39
@ginglis13 ginglis13 merged commit e4ce39b into bottlerocket-os:develop Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants