Drop k8s 1.28 and 1.29 metal variants #4287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginglis13
reviewed
Nov 7, 2024
| @@ -26,8 +26,6 @@ members = [ | |||
| "variants/aws-k8s-1.30-nvidia", | |||
| "variants/aws-k8s-1.31-nvidia", | |||
| "variants/metal-dev", | |||
| "variants/metal-k8s-1.28", | |||
There was a problem hiding this comment.
I think we should drop the corresponding settings-plugins for these variants (looks like I'd missed that in the 1.27 drop amidst the core kit shift 😅):
bottlerocket/packages/settings-plugins/settings-plugins.spec
Lines 98 to 109 in b681183
There was a problem hiding this comment.
That makes sense, I removed the defaults and plugins for metal-k8s.
yeazelm
force-pushed
the
remove-1-28-metal
branch
from
a4508e5
to
76ae7f5
Compare
ginglis13
approved these changes
Nov 7, 2024
yeazelm
force-pushed
the
remove-1-28-metal
branch
from
76ae7f5
to
5c8332f
Compare
ginglis13
approved these changes
Nov 7, 2024
Signed-off-by: Matthew Yeazel <[email protected]>
Signed-off-by: Matthew Yeazel <[email protected]>
yeazelm
force-pushed
the
remove-1-28-metal
branch
from
5c8332f
to
2d97189
Compare
cbgbt
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related to #3794
Description of changes:
This removes the metal 1.28 and 1.29 variants. Kubernetes 1.28 went end-of-life on Oct 28 and EKS end-of-life for 1.28 is November 26th and these variants are no longer supported. For more information on end of life of metal variants, please see #3794
Testing done:
Default build cargo-make succeeds and
cargo make -e BUILDSYS_VARIANT=meta-devstill works and builds the dev variant of metal.Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.