Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cert from metadata to validate response #1908

Merged
merged 6 commits into from
Nov 10, 2023
Merged

Conversation

niwsa
Copy link
Member

@niwsa niwsa commented Nov 8, 2023

What does this PR do?

  • Fixes an issue where the SAML response without an X509 certificate causes an 'Invalid Assertion error.' With Return the certs/public keys in the parsed metadata saml20#435 we now store the cert inside the idpMetadata. The stored cert will be used to validate the SAML response (will fallback to thumbprint otherwise).
  • The saved trace will now include the specific error message.

Type of change

  • Updated dependencies
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Existing unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ghost
Copy link

ghost commented Nov 8, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@niwsa niwsa changed the title Sslcert handling Use cert from metadata to validate response Nov 8, 2023
@niwsa niwsa marked this pull request as ready for review November 9, 2023 07:05
@niwsa niwsa requested a review from a team November 9, 2023 09:24
@deepakprabhakara deepakprabhakara merged commit 3c109e4 into main Nov 10, 2023
4 checks passed
@deepakprabhakara deepakprabhakara deleted the sslcert-handling branch November 10, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants