Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the attribute value as an array properly in SAMLResponse #525

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Handle the attribute value as an array properly in SAMLResponse #525

merged 4 commits into from
Feb 13, 2024

Conversation

devkiran
Copy link
Contributor

@devkiran devkiran commented Feb 8, 2024

No description provided.

@devkiran devkiran marked this pull request as ready for review February 8, 2024 05:24
@devkiran devkiran requested a review from a team February 8, 2024 05:24
@devkiran devkiran changed the title Handle the attribute value as an array properly in SAMLResponse Handle the attribute value as an array properly in SAMLResponse Feb 8, 2024
@deepakprabhakara
Copy link
Member

Let's support an additional parameter called flattenArray which will concatenate the vales with a ,

@deepakprabhakara
Copy link
Member

@devkiran Added flattenArray option and tests

@deepakprabhakara deepakprabhakara merged commit bcc26fb into main Feb 13, 2024
4 checks passed
@deepakprabhakara deepakprabhakara deleted the handle-arrays-properly branch February 13, 2024 23:39
@devkiran
Copy link
Contributor Author

Thanks @deepakprabhakara

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepakprabhakara deepakprabhakara deepakprabhakara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devkiran @deepakprabhakara