Replace existing search with pagefind + canary #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yujonglee Thank you, this looks really good |
deepakprabhakara
approved these changes
Oct 28, 2024
deepakprabhakara
merged commit 45b2713
into
boxyhq:local-pagefind-search
1 check passed
deepakprabhakara
added a commit
that referenced
this pull request
Oct 28, 2024
* move to pagefind based search (#543) * updated package-lock * tweaked tabs * added an All tab --------- Co-authored-by: yujonglee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It use
Pagefindfor local search index, andCanaryfor building search UI.Advantages:
To try locally,
npm run buildshould be called at least once, because search index is created on production build.Screen.Recording.2024-10-18.at.9.55.49.AM.mov