Skip to content

Commit

Permalink
[yugabyte#8359] Don't rebuild PostgreSQL build when switching between…
Browse files Browse the repository at this point in the history
… CLion and command line

Summary:
Before building PostgresSQL we take into account values of some environment variables to check whether build could be skipped.
One of them is PATH, but it's value is different for builds from CLion and command line.

Because of that every switch between CLion and command line causes PostgresSQL rebuild.

This diff removes PATH from this check, so postgres is not being rebuilt in above scenario.

Test Plan: Perform build from console, then switch to CLion and check that PostgresSQL build is skipped.

Reviewers: mbautin

Reviewed By: mbautin

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D11528
  • Loading branch information
spolitov committed May 9, 2021
1 parent e2fba66 commit bcb42f9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python/yb/build_postgres.py
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ def set_env_vars(self, step):
thirdparty_installed_common_bin_path = os.path.join(
self.thirdparty_dir, 'installed', 'common', 'bin')
new_path_str = ':'.join([thirdparty_installed_common_bin_path] + self.original_path)
self.set_env_var('PATH', new_path_str)
os.environ['PATH'] = new_path_str

def sync_postgres_source(self):
logging.info("Syncing postgres source code")
Expand Down

0 comments on commit bcb42f9

Please sign in to comment.