Add identifier relationship to preprint (CenterForOpenScience#2071)

bp-cos · Jan 31, 2024 · de71704 · de71704
1 parent 7e8697a
commit de71704
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 3 deletions.
diff --git a/app/models/identifier.ts b/app/models/identifier.ts
@@ -2,13 +2,14 @@ import { attr, belongsTo, AsyncBelongsTo } from '@ember-data/model';
 
 import NodeModel from './node';
 import OsfModel from './osf-model';
+import PreprintModel from './preprint';
 
 export default class IdentifierModel extends OsfModel {
     @attr('fixstring') category!: string;
     @attr('fixstring') value!: string;
 
     @belongsTo('node', { inverse: 'identifiers', polymorphic: true })
-    referent!: AsyncBelongsTo<NodeModel> & NodeModel;
+    referent!: AsyncBelongsTo<NodeModel | PreprintModel> & (NodeModel | PreprintModel);
 }
 
 declare module 'ember-data/types/registries/model' {

diff --git a/app/models/preprint.ts b/app/models/preprint.ts
@@ -8,6 +8,7 @@ import ReviewActionModel from 'ember-osf-web/models/review-action';
 
 import ContributorModel from './contributor';
 import FileModel from './file';
+import IdentifierModel from './identifier';
 import LicenseModel from './license';
 import NodeModel from './node';
 import OsfModel, { Permission } from './osf-model';
@@ -89,6 +90,9 @@ export default class PreprintModel extends OsfModel {
     @hasMany('preprint-request', { inverse: 'target'})
     requests!: AsyncHasMany<PreprintRequestModel>;
 
+    @hasMany('identifiers', { inverse: 'referent' })
+    identifiers!: AsyncHasMany<IdentifierModel>;
+
     @alias('links.doi') articleDoiUrl!: string | null;
     @alias('links.preprint_doi') preprintDoiUrl!: string;
 

diff --git a/mirage/config.ts b/mirage/config.ts
@@ -353,6 +353,11 @@ export default function(this: Server) {
         defaultSortKey: 'index',
         relatedModelName: 'subject',
     });
+    osfNestedResource(this, 'preprint', 'identifiers', {
+        path: '/preprints/:parentID/identifiers/',
+        defaultSortKey: 'index',
+        relatedModelName: 'identifier',
+    });
     this.get('/preprints/:guid/citation/:citationStyleID', getCitation);
 
     /**

diff --git a/mirage/factories/identifier.ts b/mirage/factories/identifier.ts
@@ -1,4 +1,4 @@
-import { belongsTo, Factory } from 'ember-cli-mirage';
+import { Factory } from 'ember-cli-mirage';
 import faker from 'faker';
 
 import Identifier from 'ember-osf-web/models/identifier';
@@ -8,7 +8,6 @@ export default Factory.extend<Identifier>({
     value() {
         return faker.fake('10.5555/{{company.bsNoun}}');
     },
-    referent: belongsTo({ polymorphic: true }),
 });
 
 declare module 'ember-cli-mirage/types/registries/schema' {

diff --git a/mirage/scenarios/preprints.ts b/mirage/scenarios/preprints.ts
@@ -59,6 +59,10 @@ function buildOSF(
         hasPreregLinks: PreprintPreregLinksEnum.NOT_APPLICABLE,
     });
 
+    const osfApprovedAdminIdentifier = server.create('identifier');
+
+    approvedAdminPreprint.update({ identifiers: [osfApprovedAdminIdentifier] });
+
     const notContributorPreprint = server.create('preprint', {
         provider: osf,
         id: 'osf-not-contributor',

diff --git a/mirage/serializers/preprint.ts b/mirage/serializers/preprint.ts
@@ -108,6 +108,14 @@ export default class PreprintSerializer extends ApplicationSerializer<PreprintMi
                     },
                 },
             },
+            identifiers: {
+                links: {
+                    related: {
+                        href: `${apiUrl}/v2/preprints/${model.id}/identifiers/`,
+                        meta: this.buildRelatedLinkMeta(model, 'identifiers'),
+                    },
+                },
+            },
         };
 
         if (model.license !== null) {