Address eslint across all JS files

Previously it was just looking at war/
bphinz · Aug 25, 2022 · f033a61 · f033a61
1 parent 16f0d3b
commit f033a61
Show file tree

Hide file tree

Showing 37 changed files with 346 additions and 227 deletions.
diff --git a/core/src/main/resources/hudson/PluginManager/_table.js b/core/src/main/resources/hudson/PluginManager/_table.js
@@ -403,8 +403,8 @@ Behaviour.specify("#filter-box", '_table', 0, function(e) {
             }
         }
 
-        for (var i = 0; i < pluginTRs.length; i++) {
-            initPluginRowHandling(pluginTRs[i]);
+        for (let j = 0; j < pluginTRs.length; j++) {
+            initPluginRowHandling(pluginTRs[j]);
         }
 
         setEnableWidgetStates();

diff --git a/core/src/main/resources/hudson/model/BuildTimelineWidget/build-timeline-widget.js b/core/src/main/resources/hudson/model/BuildTimelineWidget/build-timeline-widget.js
@@ -1,3 +1,5 @@
+/* global Timeline */
+
 var targetDiv = document.querySelector('#build-timeline-div');
 var tz = targetDiv.getAttribute('data-hour-local-timezone');
 var tl = null;
@@ -96,7 +98,7 @@ function doLoad() {
         window.onresize = doResize;
     }
 
-};
+}
 
 if (window.addEventListener) {
     window.addEventListener("load", doLoad, false);
@@ -108,13 +110,10 @@ if (window.addEventListener) {
 
 //add resize handle
 (function () {
-    var Dom = YAHOO.util.Dom,
-        Event = YAHOO.util.Event;
-
     var resize = new YAHOO.util.Resize('resizeContainer', {
         handles: 'b',
         minHeight: 300 // this should be the same as the height of the container div,
-        // to fix a issue when it's resized to be smaller than the original height
+        // to fix an issue when it's resized to be smaller than the original height
     });
 
     //update timeline after resizing

diff --git a/core/src/main/resources/hudson/model/Job/buildTimeTrend_resources.js b/core/src/main/resources/hudson/model/Job/buildTimeTrend_resources.js
@@ -1,11 +1,11 @@
 /**
  * Public method to be called by progressiveRendering's callback
  */
-function buildTimeTrend_displayBuilds(data) {
+window.buildTimeTrend_displayBuilds = function(data) {
 	var p = document.getElementById('trend');
 	var isDistributedBuildsEnabled = 'true' === p.getAttribute("data-is-distributed-build-enabled");
 	var rootURL = document.head.getAttribute('data-rooturl');
-	
+
 	for (var x = 0; data.length > x; x++) {
 		var e = data[x];
 		var tr = new Element('tr');
@@ -91,4 +91,4 @@ function generateSVGIcon(iconName, iconSizeClass) {
 	insert(svg2);
 
 	return span;
-}
+}
diff --git a/core/src/main/resources/hudson/model/UpdateCenter/update-center.js b/core/src/main/resources/hudson/model/UpdateCenter/update-center.js
@@ -1,4 +1,4 @@
-function submitScheduleForm(el) {
+window.submitScheduleForm = function(el) {
     var form = document.getElementById("scheduleRestart");
     form.action = el.checked ? "safeRestart" : "cancelRestart";
     crumb.appendToForm(form);
@@ -35,4 +35,4 @@ function refresh() {
     }, 5000);
 }
 window.scrollTo(0,10000);
-refresh();
+refresh();
diff --git a/core/src/main/resources/hudson/model/View/AsynchPeople/people-resources.js b/core/src/main/resources/hudson/model/View/AsynchPeople/people-resources.js
@@ -1,4 +1,4 @@
-function display(data) {
+window.display = function(data) {
     var p = document.getElementById('people');
     p.show();
     var rootURL = document.head.getAttribute('data-rooturl');

diff --git a/core/src/main/resources/hudson/views/BuildButtonColumn/icon.js b/core/src/main/resources/hudson/views/BuildButtonColumn/icon.js
@@ -4,7 +4,7 @@ Behaviour.specify(".build-button-column-icon-reference-holder", 'build-button-co
     var id = e.getAttribute('data-id');
     var icon = document.getElementById(id);
 
-    icon.onclick = function(el) {
+    icon.onclick = function() {
         new Ajax.Request(url);
         hoverNotification(message, this, -100);
         return false;

diff --git a/core/src/main/resources/jenkins/diagnostics/URICheckEncodingMonitor/adjunct.js b/core/src/main/resources/jenkins/diagnostics/URICheckEncodingMonitor/adjunct.js
@@ -1,7 +1,7 @@
 Behaviour.specify('#URICheckEncodingMonitor-message', 'URICheckEncodingMonitor', 0, function(element) {
     var url = element.getAttribute('data-url');
     var params = {value : '\u57f7\u4e8b'};
-    var checkAjax = new Ajax.Updater(
+    new Ajax.Updater(
         'URICheckEncodingMonitor-message', url,
         {
             method: 'get', parameters: params

diff --git a/core/src/main/resources/jenkins/formelementpath/form-element-path.js b/core/src/main/resources/jenkins/formelementpath/form-element-path.js
@@ -16,8 +16,10 @@ document.addEventListener("DOMContentLoaded", function(){
         function addProperty(parent, name, value) {
             name = shortenName(name);
             if (parent[name] != null) {
-                if (parent[name].push == null) // is this array?
-                    parent[name] = [parent[name]];
+                // is this array?
+                if (parent[name].push == null) {
+                  parent[name] = [parent[name]];
+                }
                 parent[name].push(value);
             } else {
                 parent[name] = value;
@@ -28,7 +30,9 @@ document.addEventListener("DOMContentLoaded", function(){
         // then return the corresponding object in the map
         function findParent(e) {
             var p = findFormParent(e, form);
-            if (p == null) return {};
+            if (p == null) {
+              return {};
+            }
 
             var m = p.formDom;
             if (m == null) {
@@ -40,24 +44,24 @@ document.addEventListener("DOMContentLoaded", function(){
             return m;
         }
 
-        var jsonElement = null;
-
-        for (var i = 0; i < form.elements.length; i++) {
+        for (let i = 0; i < form.elements.length; i++) {
             var e = form.elements[i];
             if (e.name == "json") {
-                jsonElement = e;
                 continue;
             }
-            if (e.tagName == "FIELDSET")
+            if (e.tagName == "FIELDSET") {
                 continue;
+            }
             if (e.tagName == "SELECT" && e.multiple) {
                 addProperty(findParent(e), e.name, e);
                 continue;
             }
 
             var p;
             var type = e.getAttribute("type");
-            if (type == null) type = "";
+            if (type == null) {
+              type = "";
+            }
             switch (type.toLowerCase()) {
                 case "button":
                     var element
@@ -124,37 +128,43 @@ document.addEventListener("DOMContentLoaded", function(){
         function annotate(e, path) {
             e.setAttribute("path", path);
             var o = e.formDom || {};
-            for (var key in o) {
-                var v = o[key];
 
-                function child(v, i) {
-                    var suffix = null;
-                    var newKey = key;
-                    if (v.parentNode.className && v.parentNode.className.indexOf("one-each") > -1 && v.parentNode.className.indexOf("honor-order") > -1) {
-                        suffix = v.getAttribute("descriptorId").split(".").pop()
-                    } else if (v.getAttribute("type") == "radio") {
-                        suffix = v.value
-                        while (newKey.substring(0, 8) == 'removeme')
-                            newKey = newKey.substring(newKey.indexOf('_', 8) + 1);
-                    } else if (v.getAttribute("suffix") != null) {
-                        suffix = v.getAttribute("suffix")
-                    } else {
-                        if (i > 0)
-                            suffix = i;
-                    }
-                    if (suffix == null) suffix = "";
-                    else suffix = '[' + suffix + ']';
+          function child(v, i, key) {
+            var suffix = null;
+            var newKey = key;
+            if (v.parentNode.className && v.parentNode.className.indexOf("one-each") > -1 && v.parentNode.className.indexOf("honor-order") > -1) {
+              suffix = v.getAttribute("descriptorId").split(".").pop()
+            } else if (v.getAttribute("type") == "radio") {
+              suffix = v.value
+              while (newKey.substring(0, 8) == "removeme") {
+                newKey = newKey.substring(newKey.indexOf("_", 8) + 1);
+              }
+            } else if (v.getAttribute("suffix") != null) {
+              suffix = v.getAttribute("suffix")
+            } else {
+              if (i > 0) {
+                suffix = i;
+              }
+            }
+            if (suffix == null) {
+              suffix = "";
+            } else {
+              suffix = "[" + suffix + "]";
+            }
 
-                    annotate(v, path + "/" + newKey + suffix);
-                }
+            annotate(v, path + "/" + newKey + suffix);
+          }
+
+          for (let key in o) {
+                var v = o[key];
 
                 if (v instanceof Array) {
                     var i = 0;
                     v.forEach(function (v) {
-                        child(v, i++)
+                        child(v, i++, key)
                     })
                 } else {
-                    child(v, 0)
+                    child(v, 0, key)
                 }
             }
 
@@ -163,8 +173,9 @@ document.addEventListener("DOMContentLoaded", function(){
         annotate(form, "");
 
         // clean up
-        for (i = 0; i < doms.length; i++)
-            doms[i].formDom = null;
+        for (let i = 0; i < doms.length; i++) {
+          doms[i].formDom = null;
+        }
 
         return true;
     }

diff --git a/core/src/main/resources/jenkins/management/AdministrativeMonitorsDecorator/resources.js b/core/src/main/resources/jenkins/management/AdministrativeMonitorsDecorator/resources.js
@@ -2,7 +2,9 @@
     function initializeAmMonitor(amMonitorRoot, options) {
         var button = amMonitorRoot.querySelector('.am-button');
         var amList = amMonitorRoot.querySelector('.am-list');
-        if (button === null || amList === null) return null;
+        if (button === null || amList === null) {
+          return null;
+        }
 
         var url = button.getAttribute('data-href');
 
@@ -25,7 +27,9 @@
         }
 
         function show() {
-            if (options.closeAll) options.closeAll();
+            if (options.closeAll) {
+              options.closeAll();
+            }
 
             new Ajax.Request(url, {
                 method: "GET",

diff --git a/core/src/main/resources/jenkins/security/ApiTokenProperty/resources.js b/core/src/main/resources/jenkins/security/ApiTokenProperty/resources.js
@@ -21,38 +21,38 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  * THE SOFTWARE.
  */
-function revokeToken(anchorRevoke){
+window.revokeToken = function(anchorRevoke){
     var repeatedChunk = anchorRevoke.up('.repeated-chunk');
     var tokenList = repeatedChunk.up('.token-list');
     var confirmMessage = anchorRevoke.getAttribute('data-confirm');
     var targetUrl = anchorRevoke.getAttribute('data-target-url');
-    
+
     var inputUuid = repeatedChunk.querySelector('input.token-uuid-input');
     var tokenUuid = inputUuid.value;
 
     if(confirm(confirmMessage)){
         new Ajax.Request(targetUrl, {
             method: "post",
             parameters: {tokenUuid: tokenUuid},
-            onSuccess: function(rsp,_) {
+            onSuccess: function() {
                 if(repeatedChunk.querySelectorAll('.legacy-token').length > 0){
                     // we are revoking the legacy token
                     var messageIfLegacyRevoked = anchorRevoke.getAttribute('data-message-if-legacy-revoked');
-                    
+
                     var legacyInput = document.getElementById('apiToken');
                     legacyInput.value = messageIfLegacyRevoked;
                 }
                 repeatedChunk.remove();
                 adjustTokenEmptyListMessage(tokenList);
-                
+
             }
         });
     }
 
     return false;
 }
 
-function saveApiToken(button){
+window.saveApiToken = function(button){
     if(button.hasClassName('request-pending')){
         // avoid multiple requests to be sent if user is clicking multiple times
         return;
@@ -63,11 +63,11 @@ function saveApiToken(button){
     var tokenList = repeatedChunk.up('.token-list');
     var nameInput = repeatedChunk.querySelector('[name="tokenName"]');
     var tokenName = nameInput.value;
-    
+
     new Ajax.Request(targetUrl, {
         method: "post",
         parameters: {"newTokenName": tokenName},
-        onSuccess: function(rsp,_) {
+        onSuccess: function(rsp) {
             var json = rsp.responseJSON;
             var errorSpan = repeatedChunk.querySelector('.error');
             if(json.status === 'error'){
@@ -77,11 +77,11 @@ function saveApiToken(button){
                 button.removeClassName('request-pending');
             }else{
                 errorSpan.removeClassName('visible');
-                
+
                 var tokenName = json.data.tokenName;
                 // in case the name was empty, the application will propose a default one
                 nameInput.value = tokenName;
-                
+
                 var tokenValue = json.data.tokenValue;
                 var tokenValueSpan = repeatedChunk.querySelector('.new-token-value');
                 tokenValueSpan.innerText = tokenValue;
@@ -101,15 +101,15 @@ function saveApiToken(button){
 
                 // we do not want to allow user to create twice a token using same name by mistake
                 button.remove();
-                
+
                 var revokeButton = repeatedChunk.querySelector('.token-revoke');
                 revokeButton.removeClassName('hidden-button');
-                
+
                 var cancelButton = repeatedChunk.querySelector('.token-cancel');
                 cancelButton.addClassName('hidden-button')
-                
+
                 repeatedChunk.addClassName('token-list-fresh-item');
-                
+
                 adjustTokenEmptyListMessage(tokenList);
             }
         }