Skip to content

Commit

Permalink
remove sbt-explicit-dependencies because it gives false positives for…
Browse files Browse the repository at this point in the history
… ScalaJS libraries
  • Loading branch information
bpholt committed Apr 12, 2021
1 parent 5645f74 commit 00fe926
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ jobs:
- name: Check that workflows are up to date
run: sbt ++${{ matrix.scala }} githubWorkflowCheck

- name: Build and test project
run: sbt ++${{ matrix.scala }} undeclaredCompileDependenciesTest unusedCompileDependenciesTest test
- name: Build project
run: sbt ++${{ matrix.scala }} test

- name: Compress target directories
run: tar cf targets.tar target core/js/target core/jvm/target project/target
Expand Down
2 changes: 0 additions & 2 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ inThisBuild(List(
githubWorkflowJavaVersions := Seq("[email protected]", "[email protected]"),
githubWorkflowTargetTags ++= Seq("v*"),
githubWorkflowPublishTargetBranches := Seq(RefPredicate.StartsWith(Ref.Tag("v"))),
githubWorkflowBuild := Seq(WorkflowStep.Sbt(List("undeclaredCompileDependenciesTest", "unusedCompileDependenciesTest", "test"), name = Some("Build and test project"))),
githubWorkflowPublish := Seq(
WorkflowStep.Sbt(
List("ci-release"),
Expand All @@ -49,7 +48,6 @@ lazy val `java-time-literals` = crossProject(JSPlatform, JVMPlatform)
.in(file("core"))
.settings(Seq(
description := "Parse string literals into `java.time` instances at compile time",
unusedCompileDependenciesFilter -= moduleFilter("org.scala-lang", "scala-reflect"),
libraryDependencies ++= {
val scalaReflect: immutable.Seq[ModuleID] =
if (scalaVersion.value.startsWith("3")) Nil
Expand Down
1 change: 0 additions & 1 deletion project/plugins.sbt
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
addSbtPlugin("com.geirsson" % "sbt-ci-release" % "1.5.7")
addSbtPlugin("io.github.davidgregory084" % "sbt-tpolecat" % "0.1.17")
addSbtPlugin("com.github.cb372" % "sbt-explicit-dependencies" % "0.2.16")
addSbtPlugin("com.codecommit" % "sbt-github-actions" % "0.10.1")
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.5.1")
addSbtPlugin("org.portable-scala" % "sbt-scalajs-crossproject" % "1.0.0")

0 comments on commit 00fe926

Please sign in to comment.