Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move template group right below documentation group #130

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

misiekhardcore
Copy link
Contributor

@misiekhardcore misiekhardcore commented Nov 29, 2024

closes camunda/camunda-modeler#4617

Proposed Changes

These changes are moving Template group higher on the properties panel list, right below the documentation group

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 29, 2024
@misiekhardcore misiekhardcore requested review from barmac, a team and philippfromme and removed request for a team November 29, 2024 12:06
@misiekhardcore misiekhardcore force-pushed the 4617-template-selector-is-misplaced branch from 782fd2f to fe8490c Compare November 29, 2024 12:07
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ✅ I added a commit to test all of the groups we always expect to be visible.

@philippfromme philippfromme merged commit 55cc4e5 into main Dec 2, 2024
8 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 2, 2024
@philippfromme philippfromme deleted the 4617-template-selector-is-misplaced branch December 2, 2024 10:06
@nikku
Copy link
Member

nikku commented Dec 2, 2024

Cf. camunda/camunda-modeler#4617 (comment), potentially relevant for future cross-repository contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template selector is misplaced
3 participants