Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change incompatible button text color to more accessible #140

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

jarekdanielak
Copy link
Contributor

Change text color on incompatible templates button.

npx @bpmn-io/sr bpmn-io/bpmn-js-element-templates#incompatible-color

Related to camunda/camunda-modeler#4766

Proposed Changes

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@jarekdanielak jarekdanielak self-assigned this Jan 17, 2025
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 17, 2025
@barmac
Copy link
Member

barmac commented Jan 17, 2025

Ubuntu job is failing due to missing bpmn-io/actions/setup step. I will add it directly to the PR.

@barmac
Copy link
Member

barmac commented Jan 17, 2025

OK so the action is already added. We need to investigate this.

Copy link

@lmbateman lmbateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No contrast issues reported by axe DevTools or WAVE! I think we're good to go.

image

@jarekdanielak jarekdanielak merged commit f311ff3 into main Jan 17, 2025
5 of 7 checks passed
@jarekdanielak jarekdanielak deleted the incompatible-color branch January 17, 2025 17:43
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants