Skip to content

Commit

Permalink
test(e2e): harmonize test fixtures
Browse files Browse the repository at this point in the history
  • Loading branch information
Niklas Kiefer committed Jul 3, 2023
1 parent fa592ec commit 0f3152a
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 27 deletions.
21 changes: 0 additions & 21 deletions e2e/axe-test.js

This file was deleted.

33 changes: 33 additions & 0 deletions e2e/test-fixtures.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import { test as base } from '@playwright/test';
import AxeBuilder from '@axe-core/playwright';

const DEFAULT_AXE_TAGS = [
'best-practice',
'wcag2a',
'wcag2aa',
'cat.semantics',
'cat.forms'
];

const DEFAULT_DISABLE_RULES = [
'page-has-heading-one'
];

const test = base.extend({
makeAxeBuilder: async ({ page }, use) => {
const makeAxeBuilder = (options = {}) => {
const {
tags = DEFAULT_AXE_TAGS,
disableRules = DEFAULT_DISABLE_RULES
} = options;

return new AxeBuilder({ page })
.withTags(tags)
.disableRules(disableRules);
};

await use(makeAxeBuilder);
},
});

export { test };
6 changes: 3 additions & 3 deletions e2e/visual/no-theme.spec.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
const { expect } = require('@playwright/test');

const { test: axeTest } = require('../axe-test');
const { test } = require('../test-fixtures');

const schema = require('./fixtures/form.json');

axeTest('no-theme - viewer', async ({ page, makeAxeBuilder }) => {
test('no-theme - viewer', async ({ page, makeAxeBuilder }) => {

// given
await page.route('/form', route => {
Expand Down Expand Up @@ -44,7 +44,7 @@ axeTest('no-theme - viewer', async ({ page, makeAxeBuilder }) => {
});


axeTest('no-theme - editor', async ({ page, makeAxeBuilder }) => {
test('no-theme - editor', async ({ page, makeAxeBuilder }) => {

// given
await page.route('/form', route => {
Expand Down
6 changes: 3 additions & 3 deletions e2e/visual/theming.spec.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
const { expect } = require('@playwright/test');

const { test: axeTest } = require('../axe-test');
const { test } = require('../test-fixtures');

const schema = require('./fixtures/form.json');

axeTest('theming - viewer', async ({ page, makeAxeBuilder }) => {
test('theming - viewer', async ({ page, makeAxeBuilder }) => {

// given
await page.route('/form', route => {
Expand Down Expand Up @@ -44,7 +44,7 @@ axeTest('theming - viewer', async ({ page, makeAxeBuilder }) => {
});


axeTest('theming - editor', async ({ page, makeAxeBuilder }) => {
test('theming - editor', async ({ page, makeAxeBuilder }) => {

// given
await page.route('/form', route => {
Expand Down

0 comments on commit 0f3152a

Please sign in to comment.