Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): Don't clip radio buttons #1140

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/TASKLIST_CARBONISATION.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ jobs:
options: --user 1001:1000
steps:
- name: Checkout form-js
uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
path: form-js
- name: Checkout Tasklist
uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
with:
repository: camunda/zeebe
token: ${{ secrets.ADD_TO_HTO_PROJECT_PAT }}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
147 changes: 98 additions & 49 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"test:visual": "playwright test visual",
"build:e2e": "vite build",
"start:visual-preview": "vite preview --port 8080 --logLevel silent &",
"start:container": "docker run --rm --network host -v $(pwd):/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.43.1 /bin/bash"
"start:container": "docker run --rm --network host -v $(pwd):/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.44.1 /bin/bash"
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -69,7 +69,7 @@
"@playwright/test": "^1.43.1",
"@rollup/plugin-alias": "^5.1.0",
"@rollup/plugin-babel": "^6.0.4",
"@rollup/plugin-commonjs": "^25.0.7",
"@rollup/plugin-commonjs": "^26.0.0",
"@rollup/plugin-json": "^6.1.0",
"@rollup/plugin-node-resolve": "^15.2.3",
"@svgr/rollup": "^8.1.0",
Expand Down
10 changes: 9 additions & 1 deletion packages/form-js-viewer/assets/form-js-base.css
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
--color-background-active: var(--cds-background-active, var(--color-grey-225-10-75));
--color-layer: var(--cds-layer, var(--cds-layer-01, var(--color-white)));
--color-layer-accent: var(--cds-layer-accent, var(--color-grey-0-0-88));
--color-background-pre: var(--cds-layer, var(--cds-layer-01, var(--color-white)));

--color-icon-base: var(--cds-icon-primary, var(--color-black));
--color-icon-inverted: var(--cds-icon-inverse, var(--color-black));
Expand All @@ -66,6 +67,7 @@
--color-borders-adornment: var(--cds-border-subtle, var(--cds-border-subtle-01, var(--color-grey-225-10-85)));
--color-borders-readonly: var(--cds-border-subtle, var(--color-grey-225-10-75));
--color-borders-inverted: var(--cds-border-inverse, var(--color-grey-225-10-90));
--color-borders-pre: var(--cds-border-subtle, var(--color-grey-225-10-85));

--color-warning: var(--cds-text-error, var(--color-red-360-100-45));
--color-warning-light: var(--cds-text-error, var(--color-red-360-100-92));
Expand Down Expand Up @@ -285,7 +287,6 @@
display: flex;
align-items: center;
white-space: nowrap;
overflow: hidden;
color: var(--color-text-light);
}

Expand Down Expand Up @@ -833,6 +834,13 @@
white-space: nowrap;
}

.fjs-container .fjs-form-field-html pre,
.fjs-container .fjs-form-field-text pre {
border: 1px solid var(--color-borders-pre);
background: var(--color-background-pre);
padding: 4px;
}

.fjs-container .fjs-taglist-anchor,
.fjs-container .fjs-select-anchor,
.fjs-container .fjs-timepicker-anchor {
Expand Down
2 changes: 1 addition & 1 deletion packages/form-js-viewer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"flatpickr": "^4.6.13",
"ids": "^1.0.5",
"lodash": "^4.17.21",
"marked": "^12.0.2",
"marked": "^13.0.0",
"min-dash": "^4.2.1",
"preact": "^10.5.14"
},
Expand Down
Loading