Fix Carbonization #697
Merged
Fix Carbonization #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsgoulart
commented
Jun 29, 2023
| @@ -75,7 +75,7 @@ | |||
| --cds-border-subtle, | |||
| var(--cds-border-subtle-01, var(--color-grey-225-10-85)) | |||
| ); | |||
| --color-borders-readonly: var(--cds-border-disabled, var(--color-grey-225-10-75)); | |||
| --color-borders-readonly: var(--cds-border-subtle, var(--color-grey-225-10-75)); | |||
There was a problem hiding this comment.
vsgoulart
commented
Jun 29, 2023
| @@ -1084,7 +1085,7 @@ const DROPDOWN_STYLES = css` | |||
|
|
|||
| & .fjs-dropdownlist-item:hover, | |||
| & .fjs-dropdownlist-item.focused { | |||
| background-color: var(--cds-layer-hover, var(--cds-layer-hover-01)); | |||
| background-color: var(--cds-layer-hover); | |||
There was a problem hiding this comment.
I also took the opportunity to remove the unnecessary fallbacks
There was a problem hiding this comment.
I think while experimenting with the styles, I was able to create setups where the cds-layer-hover without a specific number wasn't specified, so that's why these fallbacks landed in initially. However, I think I pretty much misconfigured something, so it's very unlikely that this will happen.
vsgoulart
force-pushed
the
fe-2966-carbon
branch
from
0e0a47d
to
a78109c
Compare
vsgoulart
force-pushed
the
fe-2966-carbon
branch
from
a78109c
to
14e5b3d
Compare
|
I will have a look today 👍 |
pinussilvestrus
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes camunda/tasklist#2966
form-jselement or visually changes an existing component.