fix(FEEL): vars in filters are properly parsed #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skaiir
force-pushed
the
test-case-team-hto-279
branch
from
8461dc4
to
dc596fd
Compare
packages/form-js-viewer/test/spec/util/GetSchemaVariables.spec.js
Outdated
Show resolved
Hide resolved
Skaiir
force-pushed
the
test-case-team-hto-279
branch
from
dc596fd
to
8c9a139
Compare
|
@pinussilvestrus Fixed the one comment and also decided to filter null and undefined variables. Mostly so that we don't ever get that issue again. |
pinussilvestrus
approved these changes
Jul 12, 2023
| variables = [ ...variables, ...templateVariables ]; | ||
| } | ||
| }); | ||
|
|
||
| return variables; | ||
| return variables.filter(variable => variable !== undefined || variable !== null); |
There was a problem hiding this comment.
Not 100% sure about this one. The good thing about the current behavior (keeping null values) was that we catched the error in Tasklist really easily and it didn't slip our attention. However we should not crash the whole workflow, so I believe it's fine now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/camunda/team-hto/issues/279