Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide empty rows via css #720

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix: hide empty rows via css #720

merged 1 commit into from
Jul 18, 2023

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Jul 17, 2023

Closes #684

Initially tried to approach this one programmatically, but it's not as clean as it seems, so I thought the simplest and most effective approach is to just not render the row if it has no children.

@Skaiir Skaiir self-assigned this Jul 17, 2023
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 17, 2023
@Skaiir Skaiir changed the base branch from develop to master July 17, 2023 12:54
Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works 👍

@pinussilvestrus pinussilvestrus merged commit 99afc3f into master Jul 18, 2023
9 of 11 checks passed
@pinussilvestrus pinussilvestrus deleted the 684-hide-empty-rows branch July 18, 2023 08:39
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Hidden components take up some space
2 participants