Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: empty form editor state #725

Merged
merged 1 commit into from
Jul 26, 2023
Merged

feat: empty form editor state #725

merged 1 commit into from
Jul 26, 2023

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Jul 18, 2023

Closes #336

@Skaiir Skaiir self-assigned this Jul 18, 2023
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 18, 2023
@github-actions github-actions bot temporarily deployed to demo-336-proper-empty-state July 24, 2023 07:15 Destroyed
@pinussilvestrus
Copy link
Contributor

We need to update some screenshots for the visual regression tests as we have empty forms over there - that is expected. Let me take this 📸

https://github.com/bpmn-io/form-js/actions/runs/5590547092/job/15141869294?pr=725

@pinussilvestrus pinussilvestrus mentioned this pull request Jul 24, 2023
Merged
@github-actions github-actions bot temporarily deployed to demo-336-proper-empty-state July 24, 2023 07:28 Destroyed
@github-actions github-actions bot temporarily deployed to demo-336-proper-empty-state July 24, 2023 07:29 Destroyed
pinussilvestrus
pinussilvestrus approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it looks clean 🥇

I'm adding @RomanKostka and @christian-konrad to have a look as well, please find here the demo: https://demo-336-proper-empty-state--camunda-form-playground.netlify.app/

christian-konrad
christian-konrad approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@christian-konrad christian-konrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! Let's go

RomanKostka
RomanKostka requested changes Jul 24, 2023
View reviewed changes
Copy link

@RomanKostka RomanKostka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!
one thing i would like to change:
add a . after each sentence - this makes the message clearer to read.
Example:
image

One aditional thing that is not related to this issue:
We should probably try to align the BPMN.IO logo in the definition + preview window so that is stays at the same height.
Examples:
image
image

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Jul 24, 2023
@github-actions github-actions bot temporarily deployed to demo-336-proper-empty-state July 24, 2023 13:22 Destroyed
@github-actions github-actions bot temporarily deployed to demo-336-proper-empty-state July 25, 2023 12:26 Destroyed
@github-actions github-actions bot temporarily deployed to demo-336-proper-empty-state July 25, 2023 13:09 Destroyed
@github-actions github-actions bot temporarily deployed to demo-336-proper-empty-state July 25, 2023 13:20 Destroyed
@github-actions github-actions bot temporarily deployed to demo-336-proper-empty-state July 25, 2023 13:42 Destroyed
@github-actions github-actions bot temporarily deployed to demo-336-proper-empty-state July 26, 2023 08:46 Destroyed
@Skaiir Skaiir merged commit 221c1c6 into develop Jul 26, 2023
10 of 15 checks passed
@Skaiir Skaiir deleted the 336-proper-empty-state branch July 26, 2023 08:58
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanKostka RomanKostka RomanKostka requested changes

@pinussilvestrus pinussilvestrus pinussilvestrus approved these changes

@christian-konrad christian-konrad christian-konrad approved these changes

@vsgoulart vsgoulart Awaiting requested review from vsgoulart

Assignees

@Skaiir Skaiir

Labels
deploy-preview
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proper empty state
4 participants
@Skaiir @pinussilvestrus @christian-konrad @RomanKostka