Fix bug in hasMany.set when models have custom primary keys

brabeji · Jun 27, 2014 · 9e804c2 · 9e804c2
1 parent 85ee802
commit 9e804c2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/associations/has-many-double-linked.js b/lib/associations/has-many-double-linked.js
@@ -87,13 +87,13 @@ module.exports = (function() {
 
     unassociatedObjects = newAssociations.filter(function(obj) {
       return !Utils._.find(oldAssociations, function(old) {
-        return (!!obj[foreignIdentifier] && !!old[foreignIdentifier] ? obj[foreignIdentifier] === old[foreignIdentifier] : obj.id === old.id);
+        return (!!obj[foreignIdentifier] ? obj[foreignIdentifier] === old[foreignIdentifier] : (!!obj[targetKeys[0]] ? obj[targetKeys[0]] === old[targetKeys[0]] : obj.id === old.id));
       });
     });
 
     oldAssociations.forEach(function(old) {
       var newObj = Utils._.find(newAssociations, function(obj) {
-        return (!!obj[foreignIdentifier] && !!old[foreignIdentifier] ? obj[foreignIdentifier] === old[foreignIdentifier] : obj.id === old.id);
+        return (!!obj[foreignIdentifier] ? obj[foreignIdentifier] === old[foreignIdentifier] : (!!obj[targetKeys[0]] ? obj[targetKeys[0]] === old[targetKeys[0]] : obj.id === old.id));
       });
 
       if (!newObj) {