Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port napari widgets from magicgui to qt #9

Merged
merged 8 commits into from
Jan 10, 2024
Merged

Port napari widgets from magicgui to qt #9

merged 8 commits into from
Jan 10, 2024

Conversation

niksirbi
Copy link
Member

All existing widgets have now been merged into a single meta-widget which contains multiple collapsible sub-widgets as preprocessing steps. This is achieved by using CollapsibleWidgetContainer from the latest release of brainglobe-utils.

The logic of the widget code has been disentangled from the preprocessing code as much as possible.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 167 lines in your changes are missing coverage. Please review.

Comparison is base (5016bbf) 0.00% compared to head (688c0c2) 0.00%.
Report is 1 commits behind head on dev.

Files Patch % Lines
brainglobe_template_builder/preproc.py 0.00% 72 Missing ⚠️
...ainglobe_template_builder/napari/midline_widget.py 0.00% 51 Missing ⚠️
brainglobe_template_builder/napari/mask_widget.py 0.00% 34 Missing ⚠️
brainglobe_template_builder/napari/_widget.py 0.00% 9 Missing ⚠️
brainglobe_template_builder/napari/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev      #9   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          6       8    +2     
  Lines        152     227   +75     
=====================================
- Misses       152     227   +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niksirbi niksirbi marked this pull request as ready for review January 10, 2024 19:38
@niksirbi niksirbi merged commit 27c03c4 into dev Jan 10, 2024
22 checks passed
@niksirbi niksirbi deleted the magicgui-to-qt branch January 10, 2024 19:39
alessandrofelder pushed a commit that referenced this pull request Aug 15, 2024
* create simple dropdown with qt

* connected qt mask widget

* finished first draft of mask qt widget

* made a chest of widgets

* Update collapsible widget API to latest brainglobe-utils (#8)

Co-authored-by: IgorTatarnikov <[email protected]>

* finish porting all existing widgets to qt

* merged utils and preproc modules

---------

Co-authored-by: IgorTatarnikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant