Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for IE throwing InvalidAccessError on db open. Fixes #32 #34

Closed
wants to merge 1 commit into from
Closed

Workaround for IE throwing InvalidAccessError on db open. Fixes #32 #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/angular-indexed-db.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ angular.module('indexedDB', []).provider '$indexedDB', ->

createDatabaseConnection = ->
deferred = $q.defer()
dbReq = indexedDB.open(dbName, dbVersion or 1)
# IE11 workaround - parseInt reminds IE that dbVersion is actually a number
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line exceeds maximum allowed length

dbReq = indexedDB.open(dbName, parseInt(dbVersion) or 1)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer this be wrapped around logic to detect the appropriate version of IE. Lest we make some funky incompatibility somewhere else.

dbReq.onsuccess = ->
db = dbReq.result
$rootScope.$apply ->
Expand Down