-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup basic perf CI #417
base: master
Are you sure you want to change the base?
Setup basic perf CI #417
Conversation
run: cargo bench --bench bench_memory -- --output-format bencher | tee -a output.txt | ||
|
||
- name: Store benchmark result | ||
uses: benchmark-action/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/services/brave-third-party-action-not-pinned-to-commit-sha.yaml
Cc @thypon @kdenhartog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHA1 can't be used here, the action isn't designed for that:
File not found: '/home/runner/work/_actions/benchmark-action/github-action-benchmark/6bae118c112083251560ad8b3a1ff2e43aa23351/dist/src/index.js'
https://github.com/brave/adblock-rust/actions/runs/12953281281
I've set v1.20.4
run: cargo bench --bench bench_memory -- --output-format bencher | tee -a output.txt | ||
|
||
- name: Store benchmark result | ||
uses: benchmark-action/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/services/brave-third-party-action-not-pinned-to-commit-sha.yaml
Cc @thypon @kdenhartog
The PR:
2 updates easylists*, remove file duplicates and add brave main list in the benchmarks. Also provides a script to do the next updates.
An example (from a forked repo):