-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve autocomplete suggestions matching for bookmarks #44374
Comments
@brotherJ4mes Getting to a named bookmark immediately/quickly/direct match or within the first few results makes a lot of sense. I'm not sure about reordering the priority of suggestions, it's a lot to ask people to do and even suggest they do. It's a lot to even ask users to consider removing a whole category (like bookmarks or history) for suggestions. We can take a look at extending our quick commands which is similar to vimium. |
I've got a PR which should let bookmarks be the default match, and give them a bit of a boost |
Wow y'all rock. Thanks for the quick responses and considering my feature request. If bookmarks were the default match, that would totally solve my issue. I've subcribed to your PR @fallaciousreasoning. Please let me know if I can help in any way with testing, etc. (I'm on linux if that makes any difference) |
@brotherJ4mes I updated the title per your last comment and to match the issue description and how @fallaciousreasoning fixed it. For |
Platforms
all
Description
My use case:
I'd like to be able to type the specific name of a bookmark in the URL bar and hit enter and go to that bookmark.
Specific Example:
I type "bjgh" which is the bookmark name for my own github page (arconym for "BrotherJ4mes GitHub")
I would expect this very specific string to match as one of my bookmark names and the resulting bookmark come up as the first choice. Instead, a brave (or whatever's default) search for "bjgh" is the first choice and I have to navigate down the autocomplete list to find my bookmark.
I appreciate that I can turn specific autocomplete suggestions on/off in Brave settings but I thought that turning all of them off except bookmarks would cause bookmarks to show first, but it seems search is always first no matter what.
I think it would greatly improve Brave if within the autocomplete settngs (below):
I'm a convert from Vivaldi and the analog setting there (below) allows the user to drag and drop the order of the autosuggestions, which is super nice. (I admit I am spoiled by the ultra-customizability of Vivaldi but I like Brave much more!)
Although all I want is bookmarks to show up first, I tried to make this request more general since I assume different people want different things.
I think the ability to change the autocomplete order would benefit others like those that want bookmark tagging and those that want to disable search entirely on the url bar.
For now, my workaround is to just use vimium and use the b/B to open a new tab from bookmarks. This is pretty convenient but vimium is not available on all pages and I'd love to have it built in to Brave. If another workaround, extension or setting change exists, please let me now. Thanks!
The text was updated successfully, but these errors were encountered: