Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Omnibox]: Rank bookmarks which match the user input more highly #27939

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Mar 4, 2025

Resolves brave/brave-browser#44374

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Bookmark a page and give the bookmark a unique name
  2. Enter the exact title of the bookmark
  3. It should be the default match (assuming you don't have a history entry for something very similar) and/or the name isn't very short

@fallaciousreasoning fallaciousreasoning changed the title Bookmarks rank higher [Omnibox]: Rank bookmarks which match the user input more highly Mar 4, 2025
@simonhong
Copy link
Member

IMO, we could adjust each match's relevance by overriding CalculateBookmarkMatchRelevance().
Then, we could avoid unnecessary full iteration of matches_. WDYT?

@fallaciousreasoning
Copy link
Contributor Author

@simonhong we could do that but we'd still need an iteration to handle setting allowed_to_be_default_match (and fill_into_edit) because that method doesn't get passed an AutocompleteMatch.

We could still split it into two parts (and adjust the relevance in CalculateBookmarkMatchRelevance) but I think it makes sense to do both in the same place.

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 👍🏼

@fallaciousreasoning fallaciousreasoning enabled auto-merge (squash) March 5, 2025 00:48
@fallaciousreasoning fallaciousreasoning merged commit b900f6a into master Mar 5, 2025
18 checks passed
@fallaciousreasoning fallaciousreasoning deleted the bookmarks-rank-higher branch March 5, 2025 02:46
@github-actions github-actions bot added this to the 1.78.x - Nightly milestone Mar 5, 2025
@brave-builds
Copy link
Collaborator

Released in v1.78.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve autocomplete suggestions matching for bookmarks
3 participants