Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meld's terms of use link not accessible on opt-in screen #44412

Closed
6 tasks
Uni-verse opened this issue Mar 4, 2025 · 2 comments · Fixed by brave/brave-core#27966
Closed
6 tasks

Meld's terms of use link not accessible on opt-in screen #44412

Uni-verse opened this issue Mar 4, 2025 · 2 comments · Fixed by brave/brave-core#27966
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 4, 2025

Description

Trying to tap on Meld's Terms of use will enable/disable the checkbox for opt-in

impacts both mobile and tablet UI

Steps to reproduce

  1. New install
  2. Create wallet
  3. In portfolio screen, tap Buy button
  4. Tap on Meld's Terms of use link

Actual result

Cannot access link

Image

Expected result

Should open terms of use in new tab

Reproduces how often

Easily reproduced

Brave version

1.76.72

Device

  • Brand/model: Samsung Galaxy S21, Tab S7
  • Android version: 13, 14

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@kjozwiak
Copy link
Member

kjozwiak commented Mar 5, 2025

The above requires 1.76.73 or higher for 1.76.x verification 👍

@Uni-verse
Copy link
Contributor Author

Uni-verse commented Mar 5, 2025

Verified on Samsung Galaxy S21 using version:

Brave	1.76.73 Chromium: 134.0.6998.45 (Official Build) (64-bit) 
Revision	7ce94109896c1bebebdd37d24b4ccf28e47deef0
OS	Android 14; Build/UP1A.231005.007; 34; REL
  • Verified tapping Meld's Terms of use link on opt-in screen will open ToU in another tab.
  • Verified closing ToU will automatically apply the checkbox allowing users to tap Continue to finish opt-in flow.
  • Verified opt-in screen is shown again if it is closed/dismissed and users are able to opt-in and are taken to Buy crypto page.
example example example example
Image Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants