Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Meld Terms of Use Link on Android #27966

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

Douglashdaniel
Copy link
Contributor

Description

Fixes a bug where Meld Terms of Use links was not working on Android

Resolves brave/brave-browser#44412

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet on an Android device
  2. Navigate to the Buy screen and wait for the Partner Consent modal to appear
  3. Click on the Meld Terms of use link
  4. It should open to their website in a new Tab

@Douglashdaniel Douglashdaniel self-assigned this Mar 5, 2025
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner March 5, 2025 00:10
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Mar 5, 2025
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to not block uplifts, but could we just use window.open?

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

brave-builds added a commit that referenced this pull request Mar 5, 2025
brave-builds added a commit that referenced this pull request Mar 5, 2025
@kjozwiak kjozwiak merged commit d5f6e9c into master Mar 5, 2025
19 checks passed
@kjozwiak kjozwiak deleted the fix-wallet-meld-terms-of-use-link-on-android branch March 5, 2025 02:13
@github-actions github-actions bot added this to the 1.78.x - Nightly milestone Mar 5, 2025
@brave-builds
Copy link
Collaborator

Released in v1.78.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meld's terms of use link not accessible on opt-in screen
4 participants