Skip to content

Commit

Permalink
kFooterAsNonLandmark renamed
Browse files Browse the repository at this point in the history
This constant has been renamed to `ax::mojom::Role::kSectionFooter`.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/03a093c456608e8deb9e0c7ce2077f09022ac3f3

commit 03a093c456608e8deb9e0c7ce2077f09022ac3f3
Author: Jocelyn Tran <[email protected]>
Date:   Fri Aug 16 15:53:13 2024 +0000

    [A11y] Rename kHeaderAsNonLandmark and kFooterAsNonLandmark

    Two new roles are being added to aria: sectionheader and sectionfooter
    [1]. header scoped to the main element or a sectioning content element
    will map to sectionheader and footer scoped to the main element or a
    sectioning content element will map to sectionfooter.

    There are two existing internal roles, kHeaderAsNonLandmark and
    kFooterAsNonLandmark, that represent these concepts so only the role
    name and output strings for the platform APIs have to be updated.

    [1] w3c/aria#1931

    Fixed: 337094897, 358159988, 358192585
  • Loading branch information
cdesouza-chromium committed Sep 9, 2024
1 parent af0264a commit 01e754c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion components/ai_chat/renderer/page_text_distilling.cc
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ static const ax::mojom::Role kRolesToSkip[]{
ax::mojom::Role::kComplementary,
ax::mojom::Role::kContentInfo,
ax::mojom::Role::kFooter,
ax::mojom::Role::kFooterAsNonLandmark,
ax::mojom::Role::kImage,
ax::mojom::Role::kLabelText,
ax::mojom::Role::kNavigation,
ax::mojom::Role::kSectionFooter,
/* input elements */
ax::mojom::Role::kTextField,
ax::mojom::Role::kTextFieldWithComboBox,
Expand Down

0 comments on commit 01e754c

Please sign in to comment.