Skip to content

Commit

Permalink
extensions::Event c'tor signature changed.
Browse files Browse the repository at this point in the history
Chromium changes:

https://source.chromium.org/chromium/chromium/src/+/776e160d358ad1dfa7c976f0a05a3f5d2b144fdb

commit 776e160d358ad1dfa7c976f0a05a3f5d2b144fdb
Author: Lei Zhang <[email protected]>
Date:   Mon May 17 23:32:40 2021 +0000

    Add more core extension code that takes std::vector<base::Value>.

    Add struct Event ctor variants, ExtensionFunction::ArgumentList()
    variant, and ExtensionFunction::ErrorWithArguments() variant that takes
    std::vector<base::Value> instead of std::unique_ptr<base::ListValue>.
    They will be used in future CLs to convert existing callers.

    Bug: 1139221

https://source.chromium.org/chromium/chromium/src/+/57d3bbe012daaa928e0cf41107a2942d7d85a8e2

commit 57d3bbe012daaa928e0cf41107a2942d7d85a8e2
Author: Lei Zhang <[email protected]>
Date:   Tue May 18 23:57:45 2021 +0000

    Remove a deprecated extension Event ctor.

    Switch callers to the equivalent non-deprecated ctor.

    Bug: 1139221
  • Loading branch information
mkarolin authored and mariospr committed Jun 4, 2021
1 parent 8449c11 commit d45db1f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions browser/brave_rewards/extension_rewards_service_observer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -307,11 +307,10 @@ void ExtensionRewardsServiceObserver::OnUnblindedTokensReady(
return;
}

auto args = std::make_unique<base::ListValue>();
std::unique_ptr<extensions::Event> event(new extensions::Event(
extensions::events::BRAVE_START,
extensions::api::brave_rewards::OnUnblindedTokensReady::kEventName,
std::move(args)));
std::vector<base::Value>()));
event_router->BroadcastEvent(std::move(event));
}

Expand Down

0 comments on commit d45db1f

Please sign in to comment.