Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.4.0 docs #161

Merged
merged 48 commits into from
May 6, 2024
Merged

Release v0.4.0 docs #161

merged 48 commits into from
May 6, 2024

Conversation

dangeross
Copy link
Contributor

This PR merges already reviewed pre-release docs into main

ok300 and others added 30 commits March 13, 2024 15:07
* Replace fetchReverseSwapFees with onchainPaymentLimits

* Fix RN snippet imports
Add prepareOnchainPayment snippets
Replace send_onchain snippets with pay_onchain
* Replace in_progress_reverse_swaps snippets with v2

* RN snippet: fix imports
Co-authored-by: Erdem Yerebasmaz <[email protected]>
…repo, add android reference implementation link
dangeross and others added 16 commits April 13, 2024 07:32
Correct android ForegroundService implementation
* Bump SDK dependency to 0.4.0-rc1

* Update Cargo.lock

* Fix GettingStarted.kt

* Update RN syntax

---------

Co-authored-by: Ross Savage <[email protected]>
* Add "receive payment" snippet for fees

* Fix dart issues

* Add snippet for receive_onchain fee info

* Simplify get_fee_info_before_receiving_payment snippet

* Fix kotlin division

* Fix kotlin CI error

* Fix RN CI error

* Fix dart CI errors

* Fix golang CI error

* Fix RN CI errors

* Fix kotlin CI error

* Fix golang CI error

* Fix kotlin CI error

* Fix kotlin CI error

* Fix RN CI error

* Fix kotlin CI error

* Fix kotlin CI error

* Fix indentation for rust snippet

* Add remaining kotlin snippets

* Add remaining RN snippets

* Add remaining dart snippets

* Fix swift snippet CI errors

* Add remaining swift snippets

* Add missing RN import

* Add remaining python snippets

* Add empty default arg in RN openChannelFee call

* Add remaining golang snippets

* Add remaining csharp snippets

* Fix golang formatting (tab indentation)

* Fix golang formatting of multi-line logs

* Fix golang formatting, add EOF newline

* Update snippets/go/communicating_fees.go

Co-authored-by: Ross Savage <[email protected]>

* Update snippets/go/communicating_fees.go

Co-authored-by: Ross Savage <[email protected]>

* Update src/guide/communicating_fees.md

Co-authored-by: Ross Savage <[email protected]>

* Update snippets/go/communicating_fees.go

Co-authored-by: Ross Savage <[email protected]>

* Update src/guide/communicating_fees.md

Co-authored-by: Ross Savage <[email protected]>

* Fix error handling in golang snippets

* Fix function name case in Kotlin snippets

* Update src/guide/communicating_fees.md

Co-authored-by: Ross Savage <[email protected]>

---------

Co-authored-by: Ross Savage <[email protected]>
@dangeross dangeross requested review from roeierez and ok300 May 6, 2024 08:32
Copy link
Contributor

@ok300 ok300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still using v0.4.0-rc5.

If the final v0.4.0 is tagged and published, we could switch to that.

@dangeross dangeross requested a review from ok300 May 6, 2024 09:49
@dangeross dangeross merged commit e177766 into main May 6, 2024
138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants