-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.4.0 docs #161
Merged
Merged
Release v0.4.0 docs #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace fetchReverseSwapFees with onchainPaymentLimits * Fix RN snippet imports
Add prepareOnchainPayment snippets
Adapt serviceHealthCheck usage
Replace send_onchain snippets with pay_onchain
* Replace in_progress_reverse_swaps snippets with v2 * RN snippet: fix imports
Co-authored-by: Erdem Yerebasmaz <[email protected]>
…repo, add android reference implementation link
(cherry picked from commit e232606)
Notification Plugin docs
Correct android ForegroundService implementation
Add payment label snippets
* Bump SDK dependency to 0.4.0-rc1 * Update Cargo.lock * Fix GettingStarted.kt * Update RN syntax --------- Co-authored-by: Ross Savage <[email protected]>
Improve notification docs
* Add "receive payment" snippet for fees * Fix dart issues * Add snippet for receive_onchain fee info * Simplify get_fee_info_before_receiving_payment snippet * Fix kotlin division * Fix kotlin CI error * Fix RN CI error * Fix dart CI errors * Fix golang CI error * Fix RN CI errors * Fix kotlin CI error * Fix golang CI error * Fix kotlin CI error * Fix kotlin CI error * Fix RN CI error * Fix kotlin CI error * Fix kotlin CI error * Fix indentation for rust snippet * Add remaining kotlin snippets * Add remaining RN snippets * Add remaining dart snippets * Fix swift snippet CI errors * Add remaining swift snippets * Add missing RN import * Add remaining python snippets * Add empty default arg in RN openChannelFee call * Add remaining golang snippets * Add remaining csharp snippets * Fix golang formatting (tab indentation) * Fix golang formatting of multi-line logs * Fix golang formatting, add EOF newline * Update snippets/go/communicating_fees.go Co-authored-by: Ross Savage <[email protected]> * Update snippets/go/communicating_fees.go Co-authored-by: Ross Savage <[email protected]> * Update src/guide/communicating_fees.md Co-authored-by: Ross Savage <[email protected]> * Update snippets/go/communicating_fees.go Co-authored-by: Ross Savage <[email protected]> * Update src/guide/communicating_fees.md Co-authored-by: Ross Savage <[email protected]> * Fix error handling in golang snippets * Fix function name case in Kotlin snippets * Update src/guide/communicating_fees.md Co-authored-by: Ross Savage <[email protected]> --------- Co-authored-by: Ross Savage <[email protected]>
Clarify webhook registration
ok300
reviewed
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still using v0.4.0-rc5
.
If the final v0.4.0
is tagged and published, we could switch to that.
Bump version to 0.4.0
ok300
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges already reviewed pre-release docs into main