Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LNURL structs #1148

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Update LNURL structs #1148

merged 1 commit into from
Dec 23, 2024

Conversation

dangeross
Copy link
Collaborator

This PR:

  • adds Clone and PartialEq traits to LNURL success action structs
  • adds anyhow error conversion to LnUrlWithdrawError

Used in breez/breez-sdk-liquid#617

@dangeross dangeross mentioned this pull request Dec 18, 2024
Merged
3 tasks
@dangeross dangeross force-pushed the savage-lnurl-common-updates branch from f77208a to c6bcb58 Compare December 18, 2024 20:54
roeierez
roeierez approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangeross dangeross merged commit a9e9e14 into main Dec 23, 2024
8 of 9 checks passed
@dangeross dangeross deleted the savage-lnurl-common-updates branch December 23, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielgranhao danielgranhao danielgranhao approved these changes

@roeierez roeierez roeierez approved these changes

@hydra-yse hydra-yse Awaiting requested review from hydra-yse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dangeross @roeierez @danielgranhao