Common BIP353 address parser #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one hickory-resolver adn exported from the sdk_common
…d to accept the dns_resolver from outside
dangeross
reviewed
Dec 20, 2024
roeierez
requested changes
Dec 20, 2024
JssDWt
reviewed
Dec 20, 2024
roeierez
requested changes
Dec 29, 2024
danielgranhao
requested changes
Jan 2, 2025
|
Oh no, thanks for nitpicking, I'm here to improve my skills and having someone to give me advice is a nice pro 😀. |
danielgranhao
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: I implemented within the sdk-common the function to parse a BIP353 address and extract the corresponding bolt12 or lnurl-pay offer. To achieve that I needed a dns-resolver and I decided to use hickory-resolver crate.
feat: edited also the cli code to integrate and inject from outside the dns_resolver dependency
This PR is the continuing part of this one breez/breez-sdk-liquid#619 in the breez-sdk-liquid repo.
I tried to implement the advice, but for the decoding part of the TXT data I decided at the moment to keep things separate from the parse_core, because of the time required to better analyze how messages are processed within the parse core.