Add freezed annotation on SDK structs used through Dart bindings #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erdemyerebasmaz with v2 of the flutter_rust_bridge do we still need to do this? |
@dangeross I'm not exactly sure if v2 changes would also generate
I'll setup an example project using v2 to find out. |
erdemyerebasmaz
force-pushed
the
freezed_annotation
branch
from
bf72aff to
0afa26f
Compare
- All SDK structs exposed through Dart bindings that reference another SDK struct has to be annotated. Including the referenced struct. - Not needed on structs that only has supported types so enums are excluded. https://cjycode.com/flutter_rust_bridge/v1/feature/lang_simple.html
erdemyerebasmaz
force-pushed
the
freezed_annotation
branch
from
0afa26f to
6af97cd
Compare
|
@erdemyerebasmaz it seems that v2 also supports structure errors so we should consider seriously to upgrade. |
I didn't want to upgrade yet as it's in beta and we were getting ready for releasing c-breez. I'll look into it. Should we merge this as there's an open PR on C-Breez that depends on this? |
|
Superseded by #940 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK structs exposed through Dart bindings that reference another SDK struct has to be annotated. Including the referenced struct.
Not needed on structs that only has supported types so enums are excluded. https://cjycode.com/flutter_rust_bridge/v1/feature/lang_simple.html